Simplify IoC for LangServer tests #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-c-martin
force-pushed
the
ant/refactor
branch
from
a277b69
to
f99c42e
Compare
jeskew
approved these changes
Oct 11, 2022
Comment on lines
+26
to
+28
| public record IOContext( | ||
| TextWriter Output, | ||
| TextWriter Error); |
| => new Program(new(Output: @out, Error: err), services | ||
| => services | ||
| .WithEmptyAzResources() | ||
| .WithFeatureOverrides(settings.FeatureOverrides) |
There was a problem hiding this comment.
How does the DI container handle multiple singletons for an interface? Does the registration for IFeatureProviderFactory performed in this method take precedence over the one performed in services.AddBicepCore() because WithFeatureOverrides is invoked first?
There was a problem hiding this comment.
The last registration wins - this callback is executed after services.AddBicepCore()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a similar setup to #8570 for injecting langauge server dependencies in integration tests.
Microsoft Reviewers: Open in CodeFlow