Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use locally cached tpn files #8330

Merged
merged 1 commit into from
Sep 12, 2022
Merged

use locally cached tpn files #8330

merged 1 commit into from
Sep 12, 2022

Conversation

majastrz
Copy link
Member

@majastrz majastrz commented Sep 10, 2022

Our GH builds are currently using an external API to generate third party notice (tpn) files. The API is somewhat flaky which is causing transient build failures. To mitigate the problem, we will use locally checked in files for GH builds with an independent build job that will run on a schedule to generate the TPN files using the API and create a PR to check them in. ADO builds will continue to rely on the API to generate TPN files.

Here's a sample PR created by the new scheduled build job: #8329

GenerateNoticeUseLocalFile: false
GenerateNoticeUpdateLocalFile: true

steps:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

steps

There isn't a good way to reuse the build logic without refactoring into scripts. We'll do that at some point...

@majastrz majastrz marked this pull request as ready for review September 10, 2022 08:40
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz majastrz merged commit c6f2324 into main Sep 12, 2022
@majastrz majastrz deleted the majastrz/local-notice-files branch September 12, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants