Support goto defintion in Visual Studio #7668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
reviewed
Jul 22, 2022
Comment on lines
37
to
40
| public async Task HandleNotificationAsync(string methodName, JToken methodParam, Func<JToken, Task> sendNotification) | ||
| { | ||
| await sendNotification(methodParam); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public async Task HandleNotificationAsync(string methodName, JToken methodParam, Func<JToken, Task> sendNotification) | |
| { | |
| await sendNotification(methodParam); | |
| } | |
| public Task HandleNotificationAsync(string methodName, JToken methodParam, Func<JToken, Task> sendNotification) => | |
| sendNotification(methodParam); |
There was a problem hiding this comment.
Updated here:
d1f7231
Thanks!
shenglol
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support goto defintion in Visual Studio.
VS lsp goto definition model is different from O#. As a part of this change, added a middle layer to convert the output obtained from bicep language server to a format that is serializable by VS language server client
.
Microsoft Reviewers: Open in CodeFlow