Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter Binder integration tests #7536

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Parameter Binder integration tests #7536

merged 5 commits into from
Jul 12, 2022

Conversation

cqthyy
Copy link
Contributor

@cqthyy cqthyy commented Jul 11, 2022 •
edited by ghost
Loading

Parameter Binder integration tests

Microsoft Reviewers: Open in CodeFlow

shenglol
shenglol reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7524 is expected to be merged soon. We should probably wait for it to be merged and then resolve conflicts.

shenglol
shenglol approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cqthyy cqthyy enabled auto-merge (squash) July 12, 2022 17:54
@cqthyy cqthyy closed this Jul 12, 2022
auto-merge was automatically disabled July 12, 2022 18:36

Pull request was closed

@cqthyy cqthyy reopened this Jul 12, 2022
@cqthyy cqthyy merged commit b365ef4 into Bicep-params-file Jul 12, 2022
@cqthyy cqthyy deleted the cqthyy/params-binder-integration-tests branch July 12, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@Usman0111 Usman0111 Awaiting requested review from Usman0111

Assignees
No one assigned
Labels
story: bicep parameters
Projects
Bicep
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cqthyy @shenglol