cqthyy/params integration unit tests

[cqthyy]

Bicep parameter file parser integration tests & baseline generation implemented, syntax visitor methods implemented

Microsoft Reviewers: Open in CodeFlow

[shenglol]

This is the same as the syntax collector visitor in PaserTests. It might be worth extracting it to a new file and make it public helper class.

[shenglol]

We can also make it a public helper method of SyntaxCollectorVisitor which both ParserTests and ParamsParserTests can reuse.

[anthony-c-martin]

+1, would be good to extract common logic here

[shenglol]

Since the we allow non-literal values at syntax level, we can add some test cases to ensure they can also be parsed, for example:

param myFunction = union({}, {})

param myComplexArrWithFunction = [
  {
    foo: resourceGroup()
  }
  true
  [
    42
  ]
]

They can also be useful for validating semantic diagnostics later, since we are going to implement semantic checking to block non-literal values.

[anthony-c-martin]

Rather than skipping over tests you want to ignore with a return (which will result in these tests being reported as "success"), it would be better to change the GetData method below to something like GetParamsData and do the filtering there.

[shenglol]

I forgot to comment this. GetData already does the filtering, but it makes sense to change the name to GetParamsData. Also, I think it's better to throw new InvalidOperationException($"Expected {dataSet.BicepParam} to be non-null"); here in case DataSets.ParamDataSets returns null BicepParam.

[majastrz]

[anthony-c-martin]

Git by default will convert line endings depending on whether you're checking out code on Windows (\r\n) or Unix/Linux (\n). This causes problems for the baseline tests - to fix this, you may need to copy the config we added for .bicep to your new extension - to respect the newline format of the file and avoid converting on different platforms:

bicep/.gitattributes

Lines 1 to 2 in 6d0eeaf

	*.bicep -text
	*.ts text eol=lf