Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error message for iterator loop warning. #7122

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Improved error message for iterator loop warning. #7122

merged 4 commits into from
Jun 8, 2022

Conversation

davidcho23
Copy link
Contributor

@davidcho23 davidcho23 commented Jun 7, 2022 •
edited by ghost
Loading

Fixes #4600

Microsoft Reviewers: Open in CodeFlow

@brwilkinson
Copy link
Collaborator

Thanks for this update @davidcho23 this was originally opened by @WhitWaldo so also tagging for visibility.

This update looks good and will be helpful for newcomers to Bicep.

anthony-c-martin
anthony-c-martin approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

@davidcho23 davidcho23 merged commit 137e8b2 into main Jun 8, 2022
@davidcho23 davidcho23 deleted the davidcho23/improveErrorMessageForIteratorLoop branch June 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when iterator in a loop is not used
3 participants
@davidcho23 @brwilkinson @anthony-c-martin