Return a transformed string literal from ARM transformation functions invoked with arguments that are all string literals #6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oked with arguments that are all string literals
shenglol
reviewed
May 4, 2022
| @@ -513,6 +515,73 @@ public static class SystemNamespaceType | |||
| return fileUri; | |||
| } | |||
|
|
|||
| private static TypeSymbol Base64ToStringTypeBuilder(IBinder binder, IFileResolver fileResolver, IDiagnosticWriter diagnostics, ImmutableArray<FunctionArgumentSyntax> arguments, ImmutableArray<TypeSymbol> argumentTypes) | |||
There was a problem hiding this comment.
The type builders are created to provide different armFunctionName to PerformArmConversionOfStringLiterals only, but their signatures are identical. Maybe it's worth extracting a higher order function to parameterize armFunctionName?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4134
This PR uses the ARM Expressions library to derive literal return types for ARM functions when invoked with arguments that are themselves all literal types. At present, this is only possible for ARM functions that take one or more string arguments and return a single string, but the pattern could be applied to other deterministic ARM function signatures if Bicep adds literal specializations for other primitive types.
Contributing a feature
Microsoft Reviewers: Open in CodeFlow