File content is loaded into special variables #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
Mar 30, 2022
| semanticModel.TypeManager.GetMatchedFunctionOverload(syntax) is { VariableGenerator: { } } functionOverload) | ||
| { | ||
| var variable = functionOverload.VariableGenerator(syntax, symbol, semanticModel.GetTypeInfo(syntax)); | ||
| variables.Add(syntax, new InternalVariableSymbol($"$fxv#{variables.Count}", variable)); |
There was a problem hiding this comment.
Fx - function, v - variable
majastrz
reviewed
Mar 30, 2022
majastrz
reviewed
Mar 30, 2022
majastrz
reviewed
Mar 30, 2022
shenglol
reviewed
Apr 19, 2022
shenglol
reviewed
Apr 19, 2022
shenglol
reviewed
Apr 19, 2022
shenglol
reviewed
Apr 19, 2022
…unctions-optimisation-5412
df964bf
to
2a531ca
Compare
shenglol
reviewed
Apr 21, 2022
| @@ -315,5 +314,6 @@ private ImmutableArray<ResourceMetadata> GetAllResourceMetadata() | |||
| public FileSymbol Root => this.Binder.FileSymbol; | |||
|
|
|||
| public ResourceScope TargetScope => this.Binder.TargetScope; | |||
|
|
|||
shenglol
reviewed
Apr 21, 2022
|
|
||
| namespace Bicep.Core.Semantics | ||
| { | ||
| public class FunctionVariable |
There was a problem hiding this comment.
Mind moving this to Bicep.Core.Emit as well? Otherwise it looks good to me.
majastrz
reviewed
Apr 21, 2022
|
|
||
| if (variableAccessSyntax is ExplicitVariableAccessSyntax) |
There was a problem hiding this comment.
majastrz
reviewed
Apr 21, 2022
| /// <summary> | ||
| /// Represents an explicit reference to a variable | ||
| /// </summary> | ||
| public class ExplicitVariableAccessSyntax: VariableAccessSyntax |
majastrz
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing a feature
File loading functions are now loading files into special variables starting with
$sign to avoid being overlapped by users. Then, in place where function is actually called, only variable access is emitted.This will help to avoid duplicating file content when load functions are used in variables that need to be inlined.
If the loadTextContent or loadFileAsBase64 is used directly in a variable declaration (
var file = loadTextContent('file.txt')) then no special symbol is emitted.Fixes #5412