upgraded to omnisharp server and client 18 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
commented
Oct 7, 2020
| @@ -34,7 +36,7 @@ public async Task EmptyFileShouldProduceDeclarationCompletions() | |||
| const string expectedSetName = "declarations"; | |||
| var uri = DocumentUri.From($"/{this.TestContext!.TestName}"); | |||
|
|
|||
| using var client = await IntegrationTestHelper.StartServerWithText(string.Empty, uri); | |||
| using var client = await IntegrationTestHelper.StartServerWithTextAsync(string.Empty, uri); | |||
There was a problem hiding this comment.
One of the new packages brought in some sort of threading analyzer which wanted to call things *Async if they are awaitable. I thought it made sense so didn't fight it too much.
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=========================================
Coverage ? 95.00%
=========================================
Files ? 235
Lines ? 9100
Branches ? 0
=========================================
Hits ? 8645
Misses ? 455
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
majastrz
commented
Oct 7, 2020
| @@ -17,19 +17,19 @@ namespace Bicep.LanguageServer | |||
| { | |||
| public class BicepCompilationManager : ICompilationManager | |||
| { | |||
| private readonly ILanguageServer server; | |||
| private readonly ILanguageServerFacade server; | |||
There was a problem hiding this comment.
This took me forever to figure out. It was failing on startup with a useless exception. Ended trying a ton of different things and eventually read the omnisharp "breaking changes" PRs where they mentioned this change 🤦♂️.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to omnisharp server and client 18. (Dependabot couldn't do it automatically due to breaking changes.) Theoretically this fixes the PrepareRename handler, so we can leverage it and make it easier to run the language server as-is in the playground.