-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added deployment().properties.template.contentVersion property #5727
Added deployment().properties.template.contentVersion property #5727
Conversation
The 4 errors come from: |
@@ -177,6 +177,10 @@ private static ObjectType GetDeploymentReturnType(ResourceScope targetScope) | |||
new TypeProperty("name", LanguageConstants.String), | |||
new TypeProperty("properties", new ObjectType("properties", TypeSymbolValidationFlags.Default, new [] | |||
{ | |||
new TypeProperty("template", new ObjectType("properties", TypeSymbolValidationFlags.Default, new [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although for templateLink is this same case, I think it would be better if object name in ObjecType constructor matched the property name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! We could rename this one "properties" -> "TemplateProperties", and the other (line 184) "properties" -> "TemplateLinkProperties". @slapointe would you mind fixing both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just keep the camelCase style: templateProperties
, templateLinkProperties
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
There are a few occurences elsewhere in the same file like that. Do you want me to fix them all?
private static ObjectType GetEnvironmentReturnType()
{
return new ObjectType("environment", TypeSymbolValidationFlags.Default, new[]
{
new TypeProperty("activeDirectoryDataLake", LanguageConstants.String),
new TypeProperty("authentication", new ObjectType("authentication", TypeSymbolValidationFlags.Default, new []
{
new TypeProperty("audiences", new TypedArrayType(LanguageConstants.String, TypeSymbolValidationFlags.Default)),
new TypeProperty("identityProvider", LanguageConstants.String),
new TypeProperty("loginEndpoint", LanguageConstants.String),
new TypeProperty("tenant", LanguageConstants.String),
}, null)),
new TypeProperty("batch", LanguageConstants.String),
new TypeProperty("gallery", LanguageConstants.String),
new TypeProperty("graph", LanguageConstants.String),
new TypeProperty("graphAudience", LanguageConstants.String),
new TypeProperty("media", LanguageConstants.String),
new TypeProperty("name", LanguageConstants.String),
new TypeProperty("portal", LanguageConstants.String),
new TypeProperty("resourceManager", LanguageConstants.String),
new TypeProperty("sqlManagement", LanguageConstants.String),
new TypeProperty("suffixes", new ObjectType("suffixes", TypeSymbolValidationFlags.Default, new []
{
new TypeProperty("acrLoginServer", LanguageConstants.String),
new TypeProperty("azureDatalakeAnalyticsCatalogAndJob", LanguageConstants.String),
new TypeProperty("azureDatalakeStoreFileSystem", LanguageConstants.String),
new TypeProperty("azureFrontDoorEndpointSuffix", LanguageConstants.String),
new TypeProperty("keyvaultDns", LanguageConstants.String),
new TypeProperty("sqlServerHostname", LanguageConstants.String),
new TypeProperty("storage", LanguageConstants.String),
}, null)),
new TypeProperty("vmImageAliasDoc", LanguageConstants.String),
}, null);
}
In this example suffixes
& authentication
in GetEnvironmentReturnType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, let me know if that's good with you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had one minor comment that would be good to fix up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
c35f3ff
to
7caef0c
Compare
I merged changes of @miqm that were conflicting with mine |
|
Looks great! |
deployment().properties.template.contentVersion
property to AzNamespaceType classFixes #3114
Contributing a feature