Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use-protectedsettings-for-commandtoexecute-secrets -> protect-command… #5591

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Jan 6, 2022

use-protectedsettings-for-commandtoexecute-secrets -> protect-commandtoexecute-secrets

Fixes #5434

This is a breaking change for the bicep.config and #disable-next-line, but I think worth it (new rule, so not many people will be using it yet).

new aka.ms added: https://aka.ms/bicep/linter/protect-commandtoexecute-secrets -> https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/linter-rule-use-protectedsettings-for-commandtoexecute-secrets
I'm not changing the documentation URLs.
The old aka.ms doc link is still active so doc links for older bicep versions will continue to work: https://aka.ms/bicep/linter/use-protectedsettings-for-commandtoexecute-secrets

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz
Copy link
Member

@StephenWeatherford can you update #2192 to make sure we mention the breaking change in release notes?

@StephenWeatherford
Copy link
Contributor Author

StephenWeatherford can you update #2192 to make sure we mention the breaking change in release notes?

Done, thanks.

@StephenWeatherford StephenWeatherford mentioned this pull request Jan 11, 2022
26 tasks
@StephenWeatherford StephenWeatherford merged commit c23c077 into main Jan 11, 2022
@StephenWeatherford StephenWeatherford deleted the sw/protect-commandtoexecute-secrets branch January 11, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorten linter id "use-protectedsettings-for-commandtoexecute-secrets"
3 participants