Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove light bulb that allows disabling linter rules in the bicep.config #5314

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Dec 2, 2021

Removes the light bulb that allows disabling linter rules in the bicep.config (in favor of the light bulb that disables just on the next line)

Fixes #5191

@bhsubra bhsubra merged commit 7509736 into main Dec 3, 2021
@bhsubra bhsubra deleted the dev/bhsubra/RemoveDisableLinterRuleLightBulb branch December 3, 2021 17:34
StephenWeatherford pushed a commit that referenced this pull request Jan 26, 2022
StephenWeatherford pushed a commit that referenced this pull request Jan 26, 2022
StephenWeatherford pushed a commit that referenced this pull request Jan 28, 2022
StephenWeatherford pushed a commit that referenced this pull request Feb 11, 2022
StephenWeatherford pushed a commit that referenced this pull request Mar 1, 2022
StephenWeatherford pushed a commit that referenced this pull request Mar 1, 2022
StephenWeatherford pushed a commit that referenced this pull request Mar 8, 2022
StephenWeatherford pushed a commit that referenced this pull request Mar 11, 2022
StephenWeatherford added a commit that referenced this pull request Mar 29, 2022
* Revert 'Remove light bulb that allows disabling linter rules in the bicepconfig.json (#5314)'

* Lightbulb/cmd to edit config

* remove unused 'server'

* fix CR comment

* simple CR fixes

* fix build

* fix tests

* handle } on same line

* CR fix

* Fix targetFolder

* unused code

* CR fixes

* use StrictMock

* Improve test failure msg

* fix lint

* better error handling

* whoops

* force creation of special folder

* fix test - create temp folder

* fix unit test

* try to fix tests

* lint

* try again

* fix path issues

Co-authored-by: Stephen Weatherford <[email protected]>
Co-authored-by: Stephen Weatherford <Stephen.Weatherford.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants