Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RG().location/et al => location param in snippets #5226

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Nov 22, 2021

Fixes #5225

This replaces current inconsistent use of location in the snippets to always be a reference to a location parameter (with a tab stop so its overwritable), instead of resourceGroup().location or 'location' or otherss:

resource ... {
location: location (as a tab top)
...}|

@StephenWeatherford StephenWeatherford marked this pull request as ready for review December 6, 2021 18:43
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz majastrz merged commit 7b0ed6f into main Dec 8, 2021
@majastrz majastrz deleted the sw/location-in-snippets branch December 8, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippets should use "location" parameter instead of resourceGroup().location or 'location' or other options
2 participants