Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test execution time #4889

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Oct 18, 2021

Improve test execution time

Before:
image

After:
image

@bhsubra bhsubra marked this pull request as draft October 18, 2021 08:35
@bhsubra bhsubra force-pushed the dev/bhsubra/ImproveTestExecutionTime branch from ab4d78f to ece8fa6 Compare October 18, 2021 09:08
@bhsubra bhsubra requested a review from majastrz October 18, 2021 15:59
@bhsubra bhsubra marked this pull request as ready for review October 18, 2021 16:00
@anthony-c-martin
Copy link
Member

Nice speedup!


private static IModuleRestoreScheduler CreateMockModuleRestoreScheduler()
{
var moduleDispatcher = Repository.Create<IModuleDispatcher>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could get rid of the MockRepository by using StrickMock.Of<IModuleDispatcher>().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it here:
0798a18

Thanks!

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz
Copy link
Member

This is amazing!

@majastrz majastrz merged commit dc4187d into main Oct 19, 2021
@majastrz majastrz deleted the dev/bhsubra/ImproveTestExecutionTime branch October 19, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants