Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule: adminUsername-should-not-be-literal #4702

Merged
merged 7 commits into from
Oct 5, 2021

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 1, 2021

Fixes #3971

@MarcusFelling Example of the error message:

image

@@ -0,0 +1,49 @@
# AdminUserName should not be a literal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcusFelling Please review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumian will we need to sync with you when adding new linter rules so you can add them to the new docs location?

Copy link
Collaborator

@MarcusFelling MarcusFelling Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenWeatherford StephenWeatherford marked this pull request as draft October 1, 2021 15:43
@StephenWeatherford StephenWeatherford marked this pull request as ready for review October 1, 2021 18:25
@StephenWeatherford
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@StephenWeatherford StephenWeatherford merged commit 4fc99de into main Oct 5, 2021
@StephenWeatherford StephenWeatherford deleted the sw/adminusername-rule branch October 5, 2021 19:05
@StephenWeatherford StephenWeatherford mentioned this pull request Oct 5, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter Rule: Admin user names can't be literal value
3 participants