Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed generating scope for looped modules and nested resources #4639

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Fixed generating scope for looped modules and nested resources #4639

merged 4 commits into from
Sep 28, 2021

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Sep 28, 2021

  • Fix using index value in module scope
  • Fix scopes to looped child resources

Fixes #3388

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@miqm miqm requested review from anthony-c-martin, majastrz and shenglol and removed request for anthony-c-martin and majastrz September 28, 2021 20:20
@miqm miqm changed the title Fixed generating scope for looped modules and child resources Fixed generating scope for looped modules and nested resources Sep 28, 2021
majastrz
majastrz approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) September 28, 2021 21:03
@anthony-c-martin anthony-c-martin merged commit 1e9e336 into Azure:main Sep 28, 2021
@anthony-c-martin anthony-c-martin deleted the feature/scope-not-generated-3388 branch September 28, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@majastrz majastrz majastrz approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using (looped) resourceGroup symbolic name as scope results in runtime error
4 participants
@miqm @shenglol @majastrz @anthony-c-martin