Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dotnet sdk rollforward #454

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Fixed dotnet sdk rollforward #454

merged 1 commit into from
Sep 6, 2020

Conversation

majastrz
Copy link
Member

@majastrz majastrz commented Sep 5, 2020

There was a typo in the rollForward property that prevented our build from picking up higher versions installed on developer machines. (Tested on WSL.) Also disabled pre-release SDKs.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2020

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         201      201           
  Lines        6784     6784           
=======================================
  Hits         6178     6178           
  Misses        606      606           
Flag Coverage Δ
#dotnet 91.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@majastrz majastrz merged commit daa82bc into master Sep 6, 2020
@majastrz majastrz deleted the majastrz/fix-roll-forward branch September 6, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants