Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter: No hard-coded hosts rule use TTK regex #3288

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Linter: No hard-coded hosts rule use TTK regex #3288

merged 9 commits into from
Jun 23, 2021

Conversation

jfleisher
Copy link
Collaborator

@jfleisher jfleisher commented Jun 21, 2021 •
edited
Loading

Fixes #2948
Fixex #3176

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

This was linked to issues Jun 21, 2021
schema.management.azure.com should be exempted from no-hardcoded-env-urls linter validation #2948
Closed
no-hardcoded-urls should have an exception for schemas #3176
Closed
majastrz
majastrz approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jfleisher jfleisher enabled auto-merge (squash) June 23, 2021 13:56
@jfleisher jfleisher disabled auto-merge June 23, 2021 14:00
@jfleisher jfleisher closed this Jun 23, 2021
@jfleisher jfleisher reopened this Jun 23, 2021
@jfleisher jfleisher enabled auto-merge (squash) June 23, 2021 14:01
@jfleisher jfleisher merged commit feeb313 into main Jun 23, 2021
@jfleisher jfleisher deleted the dev/jofleish/noharcodedhosts branch June 23, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin left review comments

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jfleisher @majastrz @anthony-c-martin