Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comonize AzResourceTypeProvider logic #2222

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Comonize AzResourceTypeProvider logic #2222

merged 1 commit into from
Apr 12, 2021

Conversation

anthony-c-martin
Copy link
Member

The test framework is using TestResourceProvider & MockResourceProvider in a number of places, which means some of the caching logic in AzResourceTypeProvider is not being exercised.

This PR minimizes the amount of untested surface area by using the AzResourceTypeProvider for all tests, and instead supplying a minimal IResourceTypeLoader which can be stubbed out in tests.

@anthony-c-martin anthony-c-martin mentioned this pull request Apr 12, 2021
Merged
9 tasks
shenglol
shenglol approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

majastrz
majastrz approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 6a98bbf into main Apr 12, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/commonize_provider branch April 12, 2021 18:13
@anthony-c-martin anthony-c-martin mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-c-martin @shenglol @majastrz