Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic levels refactor, part 1 #194

Merged
merged 4 commits into from
Aug 13, 2020
Merged

Diagnostic levels refactor, part 1 #194

merged 4 commits into from
Aug 13, 2020

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 13, 2020 •
edited
Loading

  • Split Diagnostic into 'ErrorDiagnostic' & 'Diagnostic' (base class), added levels to the base class.
  • Diagnostic consumers (logging, lang server, playground) accept the base class, producers still produce just ErrorDiagnostic.
  • That should give us the ability to slowly migrate to supporting levels across the codebase without one giant risky refactor.

This lays the groundwork for #174

@anthony-c-martin anthony-c-martin mentioned this pull request Aug 13, 2020
Closed
majastrz
majastrz approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 24c482f into master Aug 13, 2020
@anthony-c-martin anthony-c-martin deleted the antmarti/error_refactor branch August 13, 2020 18:08
@miqm miqm mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthony-c-martin @majastrz