Fixed property value context with partially typed identifiers #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55c4e42
to
4c9b76c
Compare
majastrz
commented
Mar 17, 2021
|
|
||
| case 4 when matchingNodes[^2] is IdentifierSyntax identifier && ReferenceEquals(propertyInfo.node.Value, identifier): |
There was a problem hiding this comment.
The minimal fix would have been to change L428 to
case 4 when matchingNodes[^3] is VariableAccessSyntax variableAccess && matchingNodes[^2] is IdentifierSyntax _ && ReferenceEquals(propertyInfo.node.Value, variableAccess):
However, I've been opportunistically converting to the tail matcher pattern since it's more readable once you get used to it.
4c9b76c
to
1136e05
Compare
anthony-c-martin
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1882. Also rewrote the logic using the
SyntaxMatcher.IsTailMatch()pattern.