Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions for providers() #1877

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Conversation

anthony-c-martin
Copy link
Member

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Fixes #1630

@majastrz
Copy link
Member

Btw, I opened an internal task to clarify it in JSON functions docs. It's completely non-obvious that it's sometimes returning a single object and sometimes an array.

@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #1877 (01c97a7) into main (cf4e7ec) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   95.11%   95.55%   +0.44%     
==========================================
  Files         371      367       -4     
  Lines       21929    21822     -107     
  Branches       15        0      -15     
==========================================
- Hits        20857    20853       -4     
+ Misses       1072      969     -103     
Flag Coverage Δ
dotnet 95.55% <100.00%> (+0.01%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core.IntegrationTests/ScenarioTests.cs 100.00% <100.00%> (ø)
...UnitTests/Assertions/JTokenAssertionsExtensions.cs 95.65% <100.00%> (ø)
...cep.Core/Semantics/Namespaces/AzNamespaceSymbol.cs 100.00% <100.00%> (ø)
src/vscode-bicep/src/utils/telemetry.ts
src/vscode-bicep/src/extension.ts
src/vscode-bicep/src/utils/logger.ts
src/vscode-bicep/src/language/client.ts
src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs 40.00% <0.00%> (+6.66%) ⬆️

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 15, 2021 18:16
@anthony-c-martin anthony-c-martin merged commit ea8526c into main Mar 15, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue1630 branch March 15, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Bicep [providers] function return type is Array, but in ARM it is Object
3 participants