Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'name' parameter to avoid deployment errors while following the tutorial #1861

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

lrottach
Copy link
Contributor

Fixes #1799

Description:

  • Changed the 'name' parameter to 'storageAccountName' in the tutorial .md files 01 - 03
  • Also changed the parameter in the 01.bicep and 01.json files
  • Checked if the commands and examples work as expected

The behaviour, described in the mentioned issue is solved after changing the parameter names.
The following PowerShell command deploys the storage account as expected:

New-AzResourceGroupDeployment -TemplateFile ./main.bicep -ResourceGroupName my-rg -location westus -storageAccountName uniquelogstorage001

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

  • The contribution does not exist in any of the docs in either the root of the docs directory or the specs

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@ghost
Copy link

ghost commented Mar 14, 2021

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alex-frankel alex-frankel merged commit 12aa6f6 into Azure:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bicep tutorial deployment conflict using New-AzResourceGroupDeployment and '-name' parameter
2 participants