Replace expressions nuget package with stripped down library #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
Aug 15, 2020
| - name: Update NuGet config | ||
| # workaround for bug in setup-dotnet action (the config samples for authenticated feeds don't work) | ||
| # encryption does not work on Linux or MacOS | ||
| run: dotnet nuget update source Official --username bicep --password ${{ secrets.MSAZURE_NUGET_AUTH }} --valid-authentication-types=basic --configfile ./NuGet.config --store-password-in-clear-text |
There was a problem hiding this comment.
MSAZURE_NUGET_AUTH [](start = 89, length = 18)
After this goes in, can you remove the secret from GitHub?
majastrz
reviewed
Aug 15, 2020
majastrz
reviewed
Aug 15, 2020
majastrz
reviewed
Aug 15, 2020
majastrz
reviewed
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
fe90480 shows the diff between as-is and replaced library