Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get and Preview calls for local extensions #14841

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Aug 15, 2024

The PR corrects the issue where Get and Preview operations were incorrectly calling Delete and CreateOrUpdate.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Test this change out locally with the following install scripts (Action run 10408762864)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10408762864
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10408762864"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10408762864
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10408762864"

@shenglol shenglol force-pushed the shenglol/fix-ext-resource-get branch from 4783de2 to c174799 Compare August 15, 2024 18:26
Copy link
Contributor

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 28s ⏱️ - 10m 13s
11 039 tests  -     20  11 039 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 854 runs   - 12 923  25 854 ✅  - 12 923  0 💤 ±0  0 ❌ ±0 

Results for commit c174799. ± Comparison against base commit 4139b6c.

@shenglol shenglol enabled auto-merge (squash) August 15, 2024 18:33
@shenglol shenglol merged commit 98ed923 into main Aug 15, 2024
47 checks passed
@shenglol shenglol deleted the shenglol/fix-ext-resource-get branch August 15, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants