Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include API version for generated reference() function calls on 'existing' resources #1466

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

anthony-c-martin
Copy link
Member

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Fixes #1465

@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #1466 (68cce30) into main (b95f220) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
+ Coverage   94.71%   95.21%   +0.50%     
==========================================
  Files         352      348       -4     
  Lines       18552    18431     -121     
  Branches       14        0      -14     
==========================================
- Hits        17571    17549      -22     
+ Misses        981      882      -99     
Flag Coverage Δ
dotnet 95.21% <100.00%> (+<0.01%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core.IntegrationTests/ScopeTests.cs 100.00% <ø> (ø)
src/Bicep.Core.IntegrationTests/ScenarioTests.cs 100.00% <100.00%> (ø)
src/Bicep.Core/Emit/ExpressionConverter.cs 96.80% <100.00%> (+0.07%) ⬆️
src/vscode-bicep/src/language/client.ts
src/vscode-bicep/src/utils/logger.ts
src/vscode-bicep/src/utils/telemetry.ts
src/vscode-bicep/src/extension.ts

@anthony-c-martin anthony-c-martin added this to the v0.3 milestone Feb 4, 2021
@anthony-c-martin anthony-c-martin merged commit 0e35bed into main Feb 4, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue1465 branch February 4, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API version is skipped for existing resources
4 participants