Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Deprecate provider in Bicep configuration files #14468

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Jul 2, 2024

Decided to implement this change as a breaking change rather than a soft deprecation because:

  1. Handling edge cases where a user specifies both providers and extensions are quite expensive without altering the configuration file binding logic (binding after merging the custom configuration into the built-in configuration).
  2. Currently, the providerRegistry experimental feature is used exclusively by the Bicep team internally, so the change poses minimal risk.

Closes #14377.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test this change out locally with the following install scripts (Action run 9765195787)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9765195787
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9765195787"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9765195787
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9765195787"

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Dotnet Test Results

    72 files   -     35      72 suites   - 35   23m 24s ⏱️ - 8m 0s
10 930 tests  -     26  10 929 ✅  -     26  1 💤 ±0  0 ❌ ±0 
25 756 runs   - 12 892  25 754 ✅  - 12 891  2 💤  - 1  0 ❌ ±0 

Results for commit f09851e. ± Comparison against base commit 888a9f9.

♻️ This comment has been updated with latest results.

@shenglol shenglol enabled auto-merge (squash) July 2, 2024 02:06
@shenglol shenglol disabled auto-merge July 2, 2024 02:18
@shenglol shenglol merged commit b81102e into main Jul 2, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/deprecate-provider-3rd-iter branch July 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate providers, providerAliases, and implicitProviders in Bicep configuration
2 participants