Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the recent regression in syntax highlighting for user defined types:
SemanticTokenType.Namespace
for namespace symbols.SemanticTokenType.Type
forTypeVariableAccessSyntax
that resolves to a valid type symbol.SemanticTokenType.Keyword
fornull
,true
andfalse
type keywords.Examples of changes:
![image](https://private-user-images.githubusercontent.com/22460039/341191144-42e65336-4885-43d6-8308-ea06b762d789.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzMzg4MjksIm5iZiI6MTcyNTMzODUyOSwicGF0aCI6Ii8yMjQ2MDAzOS8zNDExOTExNDQtNDJlNjUzMzYtNDg4NS00M2Q2LTgzMDgtZWEwNmI3NjJkNzg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAzVDA0NDIwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyNjM2MTEwOGY1OWQ5NzVjZmU0NjM4MmI0ZWJlYzZjZmZmMTRmYmEzMzNkYjJlNmVjZmZmMjQ4MmE2ZTMxMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.z23iPhV3TCBRSoOvKvg7PtqxuOhyQo-hYc1j8_d8PWA)
I will look into adding tests separately since we don't currently have baselines or meaningful unit tests for syntax highlighting. (I recall we had some issues with that in the past, but will need to confirm.)
This fixes #14147
Microsoft Reviewers: Open in CodeFlow