Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] An experiment to convert bicep jsonrpc to bicep grpc #14367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jun 18, 2024

I wanted to understand the complexity involved in switching from a JSONRPC contract to a gRPC one. Ultimately I don't think it's worth pursuing, but wanted to share my changes as an FYI.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Test this change out locally with the following install scripts (Action run 9590414179)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9590414179
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9590414179"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9590414179
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9590414179"

Copy link
Contributor

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 28s ⏱️ - 8m 50s
10 891 tests  -     20  10 889 ✅  -     21  1 💤 ±0  1 ❌ +1 
25 678 runs   - 12 835  25 674 ✅  - 12 836  2 💤  - 1  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 771389c. ± Comparison against base commit e307d17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant