Convert with + as keywords into identifiers
#14360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 9555663407) VSCode
Azure CLI
|
4f547bb
to
1a63587
Compare
1a63587
to
30c723e
Compare
| @@ -111,7 +111,7 @@ public async Task Provider_Statement_Without_As_Keyword_Should_Raise_Error() | |||
| } something | |||
| """); | |||
| result.Should().HaveDiagnostics(new[] { | |||
| ("BCP012", DiagnosticLevel.Error, "Expected the \"as\" keyword at this location."), | |||
| ("BCP305", DiagnosticLevel.Error, """Expected the "with" keyword, "as" keyword, or a new line character at this location."""), | |||
There was a problem hiding this comment.
Suggested change
| ("BCP305", DiagnosticLevel.Error, """Expected the "with" keyword, "as" keyword, or a new line character at this location."""), | |
| ("BCP305", DiagnosticLevel.Error, """Expected the "with" keyword, "as" keyword, or a newline character at this location."""), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when helping @polatengin on modular params that we have also implemented
withandasas dedicated tokens, rather than identifiers.This means that the following cannot be parsed as legitimate Bicep code:
Also closes #13347
Microsoft Reviewers: Open in CodeFlow