Add use-safe-access linter rule #14322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 9552149357) VSCode
Azure CLI
|
jeskew
reviewed
Jun 14, 2024
|
|
||
| [TestMethod] | ||
| public void Codefix_fixes_syntax_which_can_be_simplified() => AssertCodeFix(""" | ||
| param foo object |
There was a problem hiding this comment.
nit: Since """ removes leading spaces, it would be nice to have these indented.
There was a problem hiding this comment.
My preference is not to indent, even though it is supported by C#. For some tests, the preceding whitespace is meaningful to Bicep. I also like to be able to copy+paste directly from .bicep file <-> code block; I find the formatting is often broken by the editor when attempting to indent.
|
nice |
StephenWeatherford
approved these changes
Jun 14, 2024
| [TestMethod] | ||
| public void Rule_ignores_syntax_which_cannot_be_simplified() => AssertNoDiagnostics(""" | ||
| param foo object | ||
| var test = contains(foo, 'bar') ? foo.baz : 'baz' |
There was a problem hiding this comment.
Is property access in Azure case-sensitive?
anthony-c-martin
force-pushed
the
ant/rule
branch
from
2431efa
to
e4058e8
Compare
anthony-c-martin
force-pushed
the
ant/rule
branch
from
e4058e8
to
2b2dc9e
Compare
jeskew
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommends against the following:
And instead suggests:
Microsoft Reviewers: Open in CodeFlow