Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index out of range for bicep format with --insert-final-newline #14193

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix index out of range for bicep format with --insert-final-newline #14193

merged 1 commit into from
May 30, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented May 30, 2024 •
edited by microsoft-github-policy-service bot
Loading

Closes #14099.

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

Dotnet Test Results

    66 files   -    30      66 suites   - 30   22m 0s ⏱️ - 11m 7s
10 876 tests +   36  10 875 ✅ +   36  1 💤 ±0  0 ❌ ±0 
25 648 runs   - 6 298  25 646 ✅  - 6 297  2 💤  - 1  0 ❌ ±0 

Results for commit 435713b. ± Comparison against base commit 8943621.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 9308124442)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9308124442
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9308124442"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9308124442
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9308124442"

davidcho23
davidcho23 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@davidcho23 davidcho23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shenglol shenglol merged commit 4d9fe1a into main May 30, 2024
45 checks passed
@shenglol shenglol deleted the shenglol/fix-insert-final-newline branch May 30, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshpatel17 harshpatel17 harshpatel17 approved these changes

@davidcho23 davidcho23 davidcho23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--insert-final-newline breaks bicep format
3 participants
@shenglol @harshpatel17 @davidcho23