Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing from Bicep templates with required parameters #14070

Merged
merged 1 commit into from
May 11, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented May 10, 2024

Resolves #13997
Resolves #14069

This PR updates the ParameterAssignmentEvaluator to only evaluate the portions of imported templates that are used. This will allow imports from Bicep templates that have required parameters, which is not supported today.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team May 10, 2024 23:47
Copy link
Contributor

github-actions bot commented May 10, 2024

Test this change out locally with the following install scripts (Action run 9039758150)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9039758150
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9039758150"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9039758150
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9039758150"

Copy link
Contributor

Dotnet Test Results

    66 files   -     33      66 suites   - 33   23m 18s ⏱️ - 8m 22s
10 887 tests  -     18  10 886 ✅  -     18  1 💤 ±0  0 ❌ ±0 
25 670 runs   - 12 825  25 668 ✅  - 12 824  2 💤  - 1  0 ❌ ±0 

Results for commit 2cab358. ± Comparison against base commit 68462f0.

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew merged commit be0b3b7 into main May 11, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/13997 branch May 11, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants