Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental flag for "publishSource" #13899

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Remove experimental flag for "publishSource" #13899

merged 5 commits into from
Apr 25, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Apr 18, 2024 •
edited
Loading

Fixes #13898

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 8838236253)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8838236253
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8838236253"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8838236253
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8838236253"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited
Loading

Test Results

    64 files   -     35      64 suites   - 35   23m 29s ⏱️ - 20m 50s
10 852 tests  -     21  10 851 ✅  -     21  1 💤 ±0  0 ❌ ±0 
25 600 runs   - 12 799  25 598 ✅  - 12 798  2 💤  - 1  0 ❌ ±0 

Results for commit 6344c55. ± Comparison against base commit f2f3502.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford marked this pull request as ready for review April 25, 2024 00:34
anthony-c-martin
anthony-c-martin approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenWeatherford StephenWeatherford merged commit 52025f9 into main Apr 25, 2024
123 of 126 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/remove-f12-flag branch April 25, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephenWeatherford @anthony-c-martin