Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement: Finalize default levels for linting rules #13847

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Apr 11, 2024

Fixes #8013

NOTE: breaking change (changes 3 rules that were warning by default to off by default):

  • explicit-values-for-loc-params
  • no-hardcoded-location
  • no-loc-expr-outside-params
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Test this change out locally with the following install scripts (Action run 8727387298)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8727387298
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8727387298"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8727387298
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8727387298"

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Test Results

    66 files   -     33      66 suites   - 33   22m 44s ⏱️ - 18m 8s
10 853 tests +    80  10 852 ✅ +    80  1 💤 ±0  0 ❌ ±0 
25 602 runs   - 12 497  25 600 ✅  - 12 496  2 💤  - 1  0 ❌ ±0 

Results for commit 8494a41. ± Comparison against base commit f95b1b0.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford merged commit a2d5557 into main Apr 16, 2024
44 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/def-levels1 branch April 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement: Finalize default levels for linting rules
2 participants