#13619 secure parameter linter fix

[davidlloyduk]

Fixes #13619

What was happening was that the linter rule was falling into the default behaviour and using the default error string as it wasn't checking it was a variable assignment. Added 1 unit test to cover the basic premise of the lint rule failure.

One thing which did occur to me was that assignment of the secure parameter to a variable which is a hardcoded string isnt caught - but seemed like it should be a lint rule in of itself? Thoughts?

eg.

var blah string = 'something'

@secure()
param myparam string = blah

Should we overcomplicate the lint rule to find a reassignment of a secure parameter? Seems an illogical but valid thing to do though

[davidlloyduk]

@microsoft-github-policy-service agree

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.71%. Comparing base (108d816) to head (312a7db).
Report is 315 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #13717       +/-   ##
===========================================
- Coverage   94.28%    7.71%   -86.57%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      350   -100441     
  Branches     8734      127     -8607     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      323     -4272     
+ Partials     1168        0     -1168     

Flag	Coverage Δ
dotnet	?
typescript	7.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1106 files with indirect coverage changes

[anthony-c-martin]

Thank you for fixing this!

[github-actions]

Test this change out locally with the following install scripts (Action run 8544728506)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8544728506

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8544728506"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8544728506

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8544728506"