Add info to exception message for debugging #13655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 8329672150) VSCode
Azure CLI
|
0c7431c
to
6dfea49
Compare
6dfea49
to
738b39e
Compare
| this.parentMap = parentMap; | ||
| } | ||
|
|
||
| public static ISyntaxHierarchy Build(SyntaxBase root) | ||
| public static ISyntaxHierarchy Build(SyntaxBase root, BicepSourceFile? sourceFile = null) |
There was a problem hiding this comment.
nit: Order of parameter sourceFile is inconsistent with constructor.
There was a problem hiding this comment.
Sorry, should have clarified - this PR is just to kick off a build, I'm not planning on merging it. Doesn't look like I'm able to reject my own PR, which would have helped.
StephenWeatherford
approved these changes
Mar 18, 2024
|
Closing as we were able to identify the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to help with debugging of #13618.
Microsoft Reviewers: Open in CodeFlow