Fix official VSIX version to unblock publishing to VS gallery #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
approved these changes
Jan 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #1365 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 343 343
Lines 17415 17415
Branches 14 14
=======================================
Hits 16444 16444
Misses 971 971
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official build from https://github.com/Azure/bicep/releases/tag/v0.2.317 produced a VSIX file with a version that is rejected by the VS gallery due. This was due to the official build not setting the
PublicReleaseflag in nbgv correctly.Validated the change in the official build pipeline. Unfortunately, we will need to produce another release after this change is merged.