Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #13558 #13559

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Fix for issue #13558 #13559

merged 1 commit into from
Mar 9, 2024

Conversation

olegKoshmeliuk
Copy link
Contributor

@olegKoshmeliuk olegKoshmeliuk commented Mar 8, 2024

Closes #13558 Bicep generate-params don't emit optional parameters with --include-params All flag

Microsoft Reviewers: Open in CodeFlow

@olegKoshmeliuk
Copy link
Contributor Author

@microsoft-github-policy-service agree

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Mar 8, 2024

@olegKoshmeliuk thank you for picking this up! Would you mind adding a test?

It should be possible to make a small change to the existing test: GenerateParams_ImplicitOutputFormatJson_ExplicitIncludeParamsAll_OneParameterWithoutDefaultValue_Should_Succeed

@olegKoshmeliuk
Copy link
Contributor Author

@anthony-c-martin commited changes, test all green now. Please rerun workflow
Added test GenerateParams_ImplicitOutputFormatJson_ExplicitIncludeParamsAll_OneParameterWithDefaultValueAndOneRequiredParameter_Should_Succeed
Updated Test GenerateParams_ImplicitOutputFormatJson_ExplicitIncludeParamsAll_OneParameterWithDefaultValue_Should_Succeed
image

@anthony-c-martin
Copy link
Member

@olegKoshmeliuk thanks for contributing!

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) March 8, 2024 20:05
@anthony-c-martin anthony-c-martin merged commit 96f8e27 into Azure:main Mar 9, 2024
37 checks passed
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Test this change out locally with the following install scripts (Action run 8214431896)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8214431896
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8214431896"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8214431896
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8214431896"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bicep generate-params don't emit optional parameters with --include-params All flag
2 participants