Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for comma-separated arguments list #13504

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Mar 2, 2024

Discovered a bug while experimenting with comment formatting. If a line comment is present within the argument list of a function call or within other variable block syntax structures, formatting the code will unintentionally add a comma after the comment. This PR fixes it.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Test this change out locally with the following install scripts (Action run 8145167344)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8145167344
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8145167344"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8145167344
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8145167344"

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Test Results

    66 files   -    32      66 suites   - 32   22m 10s ⏱️ - 21m 43s
10 670 tests  -    15  10 669 ✅  -    15  1 💤 ±0  0 ❌ ±0 
25 230 runs   - 9 797  25 228 ✅  - 9 796  2 💤  - 1  0 ❌ ±0 

Results for commit 2775e17. ± Comparison against base commit 8717dd5.

@shenglol shenglol merged commit 60a197c into main Mar 4, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/fix-variable-block-formatting branch March 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants