-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading source dynamically for nested external modules #13495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this change out locally with the following install scripts (Action run 8146552724) VSCode
Azure CLI
|
959f6ca
to
f81da95
Compare
f81da95
to
d8a14bf
Compare
7e1d911
to
45f9aa5
Compare
asilverman
reviewed
Mar 1, 2024
asilverman
reviewed
Mar 1, 2024
asilverman
reviewed
Mar 1, 2024
asilverman
reviewed
Mar 1, 2024
asilverman
reviewed
Mar 1, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
asilverman
reviewed
Mar 3, 2024
asilverman
reviewed
Mar 4, 2024
asilverman
reviewed
Mar 4, 2024
asilverman
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main pieces to this (most of the rest of the changes are minor, tests, or refactoring/renaming):
NOTE: I need to do some work to handle errors better here, such as don't have permissions to restore
An example __metadata.json file with sourceArtifactId: