Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise diagnostic when whole resource body is used as a type #13494

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Feb 28, 2024

Resolves #13492

Ran into this error when working on reconciling resource-typed parameters and resource-derived types. I'd like to continue blocking using the whole resource body as a type until we figure out how to make those two experimental features work well together, but it should be blocked with an error diagnostic rather than just crashing the VS Code extension. 😅

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew force-pushed the jeskew/non-property-resource-derived-type branch from 9767ddb to 7a4e53a Compare February 28, 2024 20:40
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Test this change out locally with the following install scripts (Action run 8097736372)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8097736372
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8097736372"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8097736372
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8097736372"

Copy link
Contributor

github-actions bot commented Feb 28, 2024

Test Results

    66 files      66 suites   22m 48s ⏱️
10 670 tests 10 669 ✅ 1 💤 0 ❌
25 230 runs  25 228 ✅ 2 💤 0 ❌

Results for commit 3ea63e8.

♻️ This comment has been updated with latest results.

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeskew jeskew enabled auto-merge (squash) February 28, 2024 21:52
@jeskew jeskew merged commit c92d5a1 into main Feb 29, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/non-property-resource-derived-type branch February 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a whole resource body type as a parameter type throws an unhandled exception
2 participants