Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow function imports in .bicepparam files #13459

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Allow function imports in .bicepparam files #13459

merged 1 commit into from
Feb 27, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 26, 2024 •
edited
Loading

Closes #12911

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 8068071079)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8068071079
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8068071079"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8068071079
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8068071079"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Test Results

    66 files   -     33      66 suites   - 33   22m 9s ⏱️ - 23m 12s
10 646 tests  -     19  10 645 ✅  -     19  1 💤 ±0  0 ❌ ±0 
25 182 runs   - 12 584  25 180 ✅  - 12 583  2 💤  - 1  0 ❌ ±0 

Results for commit 5d513dd. ± Comparison against base commit d826937.

♻️ This comment has been updated with latest results.

jeskew
jeskew approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was worried this was going to be a much more involved fix.

@anthony-c-martin anthony-c-martin merged commit 98d54b4 into main Feb 27, 2024
43 of 44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/param_funcs branch February 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building bicep parameterfiles with compile-time imported UDFs, exception is thrown
2 participants
@anthony-c-martin @jeskew