Remove experimental feature for user defined functions #13458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 8072406289) VSCode
Azure CLI
|
anthony-c-martin
force-pushed
the
ant/exp/func
branch
2 times, most recently
from
5cc54be
to
6582b42
Compare
anthony-c-martin
force-pushed
the
ant/exp/func
branch
from
6582b42
to
b1bf958
Compare
jeskew
approved these changes
Feb 27, 2024
Comment on lines
+25
to
+26
| // there are any user-defined function declarations | ||
| model.Root.FunctionDeclarations.Any() || |
There was a problem hiding this comment.
This isn't strictly necessary, but it's not a bad idea for increasing symbolic name adoption.
There was a problem hiding this comment.
Yeah that was the goal. Might as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow