Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dot in resource type version pattern #13331

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Allow dot in resource type version pattern #13331

merged 1 commit into from
Feb 13, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Feb 12, 2024 •
edited by microsoft-github-policy-service bot
Loading

This is a short-term workaround to address #13327.

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7894804944)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7894804944
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7894804944"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7894804944
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7894804944"

@github-actions GitHub Actions
Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   26m 13s ⏱️ - 32m 24s
11 016 tests  -     20  11 016 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 922 runs   - 12 957  25 922 ✅  - 12 957  0 💤 ±0  0 ❌ ±0 

Results for commit 9c33cdd. ± Comparison against base commit 2953434.

@shenglol shenglol linked an issue Feb 13, 2024 that may be closed by this pull request
Resource API version doesn't support dot character #13327
Closed
@shenglol shenglol merged commit 589bc60 into main Feb 13, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/relax-api-version-pattern branch February 13, 2024 00:37
StephenWeatherford pushed a commit that referenced this pull request Feb 16, 2024
@shenglol @StephenWeatherford
Allow dot in resource type version pattern (#13331)
45e0db2 
This is a short-term workaround to address
#13327.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource API version doesn't support dot character
2 participants
@shenglol @anthony-c-martin