Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for recursive build and publish output #13292

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

majastrz
Copy link
Member

@majastrz majastrz commented Feb 10, 2024

Added support for recursive build and publish output to the MSBuild package. To avoid breaking changes, users will have to opt into the new behavior by setting the BicepOutputStyle msbuild property to Recursive. The default value for the property is Flat, which preserves the previous behavior for users who took a dependency on it.

This fixes #10989.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Feb 10, 2024

Test this change out locally with the following install scripts (Action run 7906404587)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7906404587
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7906404587"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7906404587
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7906404587"

Copy link
Contributor

github-actions bot commented Feb 10, 2024

Test Results

    65 files   -     34      65 suites   - 34   24m 27s ⏱️ - 22m 41s
11 016 tests  -     20  11 016 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 922 runs   - 12 957  25 922 ✅  - 12 957  0 💤 ±0  0 ❌ ±0 

Results for commit dd69c72. ± Comparison against base commit 589bc60.

♻️ This comment has been updated with latest results.

@majastrz majastrz marked this pull request as ready for review February 13, 2024 02:47
@majastrz majastrz changed the title add support for recursive build and publish output Added support for recursive build and publish output Feb 13, 2024
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@majastrz majastrz merged commit 1179155 into main Feb 14, 2024
44 checks passed
@majastrz majastrz deleted the majastrz/recursive branch February 14, 2024 02:04
StephenWeatherford pushed a commit that referenced this pull request Feb 16, 2024
Added support for recursive build and publish output to the MSBuild
package. To avoid breaking changes, users will have to opt into the new
behavior by setting the `BicepOutputStyle` msbuild property to
`Recursive`. The default value for the property is `Flat`, which
preserves the previous behavior for users who took a dependency on it.

This fixes #10989.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSBuild extension doesn't place compiled bicep output correctly when bicep isn't at root level
2 participants