Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flag for compile-time imports #13150

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Remove feature flag for compile-time imports #13150

merged 1 commit into from
Jan 29, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 29, 2024 •
edited
Loading

Resolves #10121
Resolves #13097

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7703079659)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7703079659
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7703079659"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7703079659
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7703079659"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Test Results

    66 files   -    19      66 suites   - 19   25m 7s ⏱️ - 13m 14s
11 008 tests  -     6  11 008 ✅  -     6  0 💤 ±0  0 ❌ ±0 
25 906 runs   - 4 536  25 906 ✅  - 4 536  0 💤 ±0  0 ❌ ±0 

Results for commit 8cff161. ± Comparison against base commit 12afdcc.

♻️ This comment has been updated with latest results.

@jeskew jeskew force-pushed the jeskew/compile-time-imports-GA branch from 2249eb5 to 8cff161 Compare January 29, 2024 19:48
@jeskew jeskew requested a review from a team January 29, 2024 20:00
@jeskew jeskew marked this pull request as ready for review January 29, 2024 20:00
anthony-c-martin
anthony-c-martin approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE 🥳 🥳 🥳 🥳 🥳 🥳 🥳

@jeskew jeskew merged commit 817ad76 into main Jan 29, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/compile-time-imports-GA branch January 29, 2024 22:06
@AlexanderSehr AlexanderSehr mentioned this pull request Jun 7, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove feature flag for compile-time imports Sharing compile-time constant values across templates
2 participants
@jeskew @anthony-c-martin