Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 12020 (better error for expr when expecting object) #13102

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Fix 12020 (better error for expr when expecting object) #13102

merged 1 commit into from
Jan 28, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Jan 25, 2024 •
edited by microsoft-github-policy-service bot

Fixes #12020

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford marked this pull request as ready for review January 25, 2024 23:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited

Test this change out locally with the following install scripts (Action run 7682951478)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7682951478
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7682951478"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7682951478
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7682951478"

@github-actions GitHub Actions
Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   24m 2s ⏱️ - 28m 53s
10 760 tests  -     18  10 760 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 783 runs   - 12 884  25 783 ✅  - 12 884  0 💤 ±0  0 ❌ ±0 

Results for commit 534207a. ± Comparison against base commit 83bd36b.

anthony-c-martin
anthony-c-martin approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StephenWeatherford StephenWeatherford merged commit 993e540 into main Jan 28, 2024
44 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/paste-crash branch January 28, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not paste clipboard text as Bicep: Cannot access child value on Newtonsoft.Json.Linq.JValue.
2 participants
@StephenWeatherford @anthony-c-martin