Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Reduce indentation to enhance readability #12978

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

asilverman
Copy link
Contributor

@asilverman asilverman commented Jan 10, 2024

Overview

Literal strings use the last """ (triple-quote) as a margin indicator, reducing the indentation here makes the code easier to follow IMO since it allows a human to scan top to bottom vs having to go in the incline from right top to left bottom which is distracting.

Microsoft Reviewers: Open in CodeFlow

@asilverman asilverman added this to the v0.25 milestone Jan 10, 2024
@asilverman asilverman self-assigned this Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jan 10, 2024

Test this change out locally with the following install scripts (Action run 7479558883)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7479558883
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7479558883"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7479558883
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7479558883"

Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   24m 17s ⏱️ - 27m 0s
10 592 tests  -     17  10 592 ✅  -     17  0 💤 ±0  0 ❌ ±0 
25 689 runs   - 12 843  25 689 ✅  - 12 843  0 💤 ±0  0 ❌ ±0 

Results for commit 906188e. ± Comparison against base commit f370c49.

@asilverman asilverman enabled auto-merge (squash) January 10, 2024 17:51
@asilverman asilverman merged commit 9cf8bf3 into main Jan 10, 2024
44 checks passed
@asilverman asilverman deleted the asilverman/maint/fix-whitespaces branch January 10, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants