Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONRPC: Add new methods #12975

Merged
merged 1 commit into from
Jan 11, 2024
Merged

JSONRPC: Add new methods #12975

merged 1 commit into from
Jan 11, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jan 10, 2024 •
edited by microsoft-github-policy-service bot
Loading

  • Add new methods "version", "getMetadata", "getDeploymentGraph"
  • Remove method "validate"
  • Add .NET test class for JSONRPC
Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7484250940)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7484250940
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7484250940"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7484250940
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7484250940"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Test Results

    63 files   -     36      63 suites   - 36   21m 53s ⏱️ - 27m 31s
10 594 tests  -     15  10 594 ✅  -     15  0 💤 ±0  0 ❌ ±0 
22 886 runs   - 15 646  22 886 ✅  - 15 646  0 💤 ±0  0 ❌ ±0 

Results for commit 696872d. ± Comparison against base commit b758387.

♻️ This comment has been updated with latest results.

majastrz
majastrz approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 1389c59 into main Jan 11, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/jsonrpc branch January 11, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthony-c-martin @majastrz